[PATCH] D84642: AMDGPU/GlobalISel: Fix selecting llvm.amdgcn.s.getreg

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 14:23:34 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:814
+  "$sdst, $simm16",
+  [(set i32:$sdst, (int_amdgcn_s_getreg (i32 timm:$simm16)))]> {
+  let SOPKZext = 1;
----------------
rampitec wrote:
> Why cannot you use as_i16imm?
Because it's a freestanding SDNodeXForm. This would require using a combination Operand+SDNodeXForm class. These should probably be merged, but that's a bigger patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84642/new/

https://reviews.llvm.org/D84642



More information about the llvm-commits mailing list