[PATCH] D84612: [openmp][openacc] Add wrapper for records in DirectiveEmitter

[Joel E. Denny via Phabricator via llvm-commits]

jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.

Should this patch be marked NFC?

Except for some tiny fixes, LGTM.  Thanks for the changes and the pointer to MLIR.



================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:44
+// Wrapper class that contains DirectiveLanguage's information defined in
+// DirectiveBase.td and provides helper methods for accessing them.
+class DirectiveLanguage {
----------------
them -> it.  "information" is singular.  Likewise in other comments below.


================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:133
+
+// Wrapper class that contains Clase's information defined in DirectiveBase.td
+// and provides helper methods for accessing them.
----------------
Clase -> Clause


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84612/new/

https://reviews.llvm.org/D84612