[PATCH] D84782: [PGO] Include the mem ops into the function hash.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 11:58:43 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:646
+                 (uint64_t)ValueSites[IPVK_IndirectCallTarget].size() << 50 |
+                 (uint64_t)ValueSites[IPVK_MemOPSize].size() << 48 |
                  (uint64_t)MST.AllEdges.size() << 32 | JC.getCRC();
----------------
2 bits for ValueSites[IPVK_MemOPSize].size(). Is that sufficient?
This deserves a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84782/new/

https://reviews.llvm.org/D84782



More information about the llvm-commits mailing list