[PATCH] D84493: [InstCombine] Disable branch predicate canonicalization

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 11:43:02 PDT 2020


kuhar added a comment.

In D84493#2171946 <https://reviews.llvm.org/D84493#2171946>, @yrouban wrote:

> In D84493#2171849 <https://reviews.llvm.org/D84493#2171849>, @lebedev.ri wrote:
>
>> In D81089#2088014 <https://reviews.llvm.org/D81089#2088014>, @kuhar wrote:
>>
>>> <..> you have to chose some arbitrary way of selecting a fake-entry node from nodes in an scc. Right now this order is whatever children or inverse_children return, but could be based on the order of blocks in a function instead.
>
> Ok. Let us try now. But why did not they do it a few years ago then?

We just missed this IIRC :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84493/new/

https://reviews.llvm.org/D84493



More information about the llvm-commits mailing list