[PATCH] D84777: AMDGPU: Check for other defs when folding conditions into s_andn2_b64

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 10:57:48 PDT 2020


arsenm created this revision.
arsenm added a reviewer: rampitec.
Herald added subscribers: kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: LLVM.
arsenm requested review of this revision.
Herald added a subscriber: wdng.

We can't fold the masked compare value through the select if the
select condition is re-used after the and instruction. Fixes a
verifier error and trying to use the outgoing value defined in the
block.

      

I'm not sure why this pass is bothering to handle physregs. It's
making this more complex and forces extra liveness computation.


https://reviews.llvm.org/D84777

Files:
  llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
  llvm/test/CodeGen/AMDGPU/optimize-exec-mask-pre-ra-loop-phi.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84777.281294.patch
Type: text/x-patch
Size: 9682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200728/16603226/attachment.bin>


More information about the llvm-commits mailing list