[PATCH] D84714: [lld-macho] Implement -headerpad

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

I think that the page offset trick that ld64 does is important.  That sounds very much like page handling for the loader to be more efficient, and I think that we should emulate that behaviour (with a comment in the code).



================
Comment at: lld/MachO/Driver.cpp:399
       args.getLastArgValue(OPT_install_name, config->outputFile);
+  config->headerPad = args::getHex(args, OPT_headerpad, 32);
   getLibrarySearchPaths(config->librarySearchPaths, args);
----------------
Would be nice to comment the default value (32).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84714/new/

https://reviews.llvm.org/D84714