[PATCH] D84733: [Attributor] Check nonnull attribute violation in AAUndefinedBehavior

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2024
                               /* CheckBBLivenessOnly */ true);
+    A.checkForAllCallLikeInstructions(InspectCallSiteForUB, *this);
     if (NoUBPrevSize != AssumedNoUBInsts.size() ||
----------------
jdoerfert wrote:
> baziotis wrote:
> > Please add a third argument specifying the instructions to check, i.e. `{Instruction::CallSite}`. Also, a fourth argument `true` as a value, like the other too above.
> No need to specify call site (which is not an opcode) because this is a specialized version of `checkForAllInstructions`. The CheckBBLivenessOnly can be provided I guess.
Oh my bad. The names are big and I missed completely that it is not `checkForAllInstructions`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84733/new/

https://reviews.llvm.org/D84733