[PATCH] D84234: [DWARFYAML] Implement the .debug_loclists section.

Tue Jul 28 06:01:17 PDT 2020

jhenderson added a comment.

In D84234#2168873 <https://reviews.llvm.org/D84234#2168873>, @jhenderson wrote:

> The DWARF v5 standard explicitly allows for a value of 0 for the offset_entry_count, meaning there are no offset entries. My reading is that this is allowed even if there are location lists, but I don't see any testing for that situation, I think? I believe the same applies for .debug_rnglists, but I haven't looked to see if you implemented that there.

I might be missing this, but was this point addressed yet?

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-loclists.yaml:757-758
+
+## t) Test that yaml2obj emits an error message if we use an unimplemented DWARF expression
+## operator.
+
----------------
Rather than a known value that we one day will likely support, causing this test to be updated, perhaps we should pick a value that isn't supported by the DWARF spec?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84234/new/

https://reviews.llvm.org/D84234