[PATCH] D84738: [yaml2obj] - Add a way to override sh_type section field.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 03:56:59 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit. I think the use-case makes sense.



================
Comment at: llvm/test/tools/yaml2obj/ELF/override-shtype.yaml:34
+    Flags:  [ SHF_ALLOC ]
+    ShType: [[TYPE=SHT_GNU_verneed]]
+    Info:   0
----------------
As you don't use the YAML for a non-overridden type, you can omit the `=SHT_GNU_verneed`, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84738/new/

https://reviews.llvm.org/D84738



More information about the llvm-commits mailing list