[PATCH] D84630: [StackSafety] Skip ambiguous lifetime analysis

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: llvm/include/llvm/Analysis/StackLifetime.h:124
 
+  bool HasUnknowLifetimeStartOrEnd = false;
+
----------------
Missing 'n' in "unknown"


================
Comment at: llvm/lib/Analysis/StackLifetime.cpp:301
+    case LivenessType::Must:
+      LiveRanges.resize(NumAllocas, LiveRange(Instructions.size()));
+      break;
----------------
Doesn't this case need the loop below? It looks like it's undoing all the extra default initialization caused by the resize.

Actually, I'd be inclined to reword the whole thing in terms of resizing with the default and separately setting `NumAllocas - 1` if that is the correct reading.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84630/new/

https://reviews.llvm.org/D84630