[PATCH] D84574: [lld-macho] Fix segment filesize calculation

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Writer.cpp:137
     for (OutputSection *osec : seg->getSections()) {
-      c->filesize += osec->getFileSize();
+      // This condition should hold unless we are dealing with a __bss section.
+      if (osec->fileOff >= seg->fileOff)
----------------
compnerd wrote:
> I wonder if that should just be an assert instead.
Agreed :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84574/new/

https://reviews.llvm.org/D84574