[PATCH] D84427: [llvm][NFC] refactor setBlockFrequency for clarity.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 16:49:43 PDT 2020


mtrofin added a comment.

In D84427#2177332 <https://reviews.llvm.org/D84427#2177332>, @davidxl wrote:

> Perhaps also keep setBlockFreq as a lower level interface? I am surprised that edge splitting is the only one user of it.


We can always add it back. Its absence makes things easier to a reader, I think, because it becomes more clear when the analysis result undergoes mutations - i.e. whenever the pass manager requests it, and during edge splitting, as a performance optimization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84427/new/

https://reviews.llvm.org/D84427





More information about the llvm-commits mailing list