[PATCH] D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic.

Mon Jul 27 09:25:12 PDT 2020

sameeranjoshi added inline comments.

================
Comment at: flang/test/Semantics/selecttype01.f90:131
   select type (a => x)
+  !ERROR : Intrinsic type specification must not be specified
   type is (integer)
----------------
inderjeet-hcl wrote:
> sameeranjoshi wrote:
> > Is this error correct? 
> > I see `check-flang` failing for both the files.
> > Did you verify `check-flang` before submitting this patch?
> > 
> sorry, I was not aware of the option check-flang. I will test it before submitting updated files.
> 
> Error seems correct, selector should be unlimited Polymorphic in case of Intrinsic type specification.
> Function ReportConflictingTypeCases is generating 'INTEGER*4' in error message instead of 'integer' which is specified in test case. Do you have any idea how to update function ReportConflictingTypeCases to display correct name ?
`4` specifies kind type parameter.
I am speaking of
`!ERROR : Intrinsic type specification must not be specified` 
replaced with
`!ERROR : If selector is not unlimited polymorphic, an intrinsic type specification must not be specified in the type guard statement`

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84290/new/

https://reviews.llvm.org/D84290