[PATCH] D83875: [XCOFF][AIX] Enable -ffunction-sections

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 09:10:34 PDT 2020


Xiangling_L added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2088
     const Function &F, const TargetMachine &TM) const {
   assert (!TM.getFunctionSections() && "Unique sections not supported on XCOFF"
           " yet.");
----------------
jasonliu wrote:
> Xiangling_L wrote:
> > Should we also handle this in this patch?
> I think this is fairly orthogonal and we could handle it with a follow up patch.
> Noted that without handling this, we might run into asserts when using function sections with jump table.
I am okay with handling this with a separate patch, but I think you may want to edit the patch description or title to indicate the limited scope of this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83875/new/

https://reviews.llvm.org/D83875





More information about the llvm-commits mailing list