[PATCH] D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour requested changes to this revision.
bmahjour added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:252
+      return false;
+    auto DestMemLoc = MemoryLocation::get(Inst);
+
----------------
MemoryLocation::get returns "none" if Inst is a call. Please add special handling for calls and make sure your tests cover it.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:260
+    // RAR dependency is safe
+    if (isRefSet(Result) && isRefSet(DestResult))
+      return false;
----------------
The ref bit could be on for mod-ref cases. Please also check to make sure they are not mod.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84589/new/

https://reviews.llvm.org/D84589