[PATCH] D84651: [llvm-readobj] - Don't call `unwrapOrErr` in `findSectionByName`.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 06:27:29 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, atanasyan, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

We have a `findSectionByName` helper that tries to find a section
by it name. It is used in a few places, but never tested.

I'd like to reuse this helper for a different place.
For this, I've changed it to return Expected<> and now it
doesn't use `unwrapOrErr` anymore too.


https://reviews.llvm.org/D84651

Files:
  llvm/test/tools/llvm-readobj/ELF/mips-abiflags.test
  llvm/test/tools/llvm-readobj/ELF/mips-got.test
  llvm/test/tools/llvm-readobj/ELF/mips-options-sec.test
  llvm/test/tools/llvm-readobj/ELF/mips-reginfo.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84651.280887.patch
Type: text/x-patch
Size: 11802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200727/5a6f062b/attachment-0001.bin>


More information about the llvm-commits mailing list