[PATCH] D83976: [Mem2Reg] Teach promote to register about droppable instructions

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/IR/Value.cpp:197
+  dropDroppableUses([&](const Use *U) { return U->getUser() == &Usr; });
+}
+
----------------
efriedma wrote:
> This seems like a dubious pattern; you're iterating over the entire use list of the value each time you call dropDroppableUsesByUser, which is likely a lot more expensive than iterating over the operand list of the assume.
@jdoerfert  @Tyker Any more thoughts on Eli's point?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83976/new/

https://reviews.llvm.org/D83976