[PATCH] D84641: AMDGPU/GlobalISel: Fix selection of s1/s16 G_[F]CONSTANT

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 05:20:53 PDT 2020


arsenm created this revision.
arsenm added reviewers: foad, kerbowa, nhaehnle, hsmhsm, madhur13490.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, rovka, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

The code to determine the value size was overcomplicated and only
correct in the case where the result register already had a register
class assigned. We can always take the size directly from the
register's type.


https://reviews.llvm.org/D84641

Files:
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/divergent-control-flow.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-and.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-constant.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fconstant.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-or.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-xor.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84641.280865.patch
Type: text/x-patch
Size: 47039 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200727/eedd2393/attachment.bin>


More information about the llvm-commits mailing list