[PATCH] D84625: Execute llvm-lit with the python found by CMake by default

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 02:40:50 PDT 2020


arichardson created this revision.
arichardson added reviewers: compnerd, thakis.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The check-* targets run ${Python3_EXECUTABLE} $BUILD/bin/llvm-lit, but
running `./bin/llvm-lit $ARGS` from the build directory currently always
uses "python" to run llvm-lit. On most systems this will be python2.7 even
if we found python3 at CMake time.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84625

Files:
  llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn
  llvm/utils/llvm-lit/llvm-lit.in


Index: llvm/utils/llvm-lit/llvm-lit.in
===================================================================
--- llvm/utils/llvm-lit/llvm-lit.in
+++ llvm/utils/llvm-lit/llvm-lit.in
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!@Python3_EXECUTABLE@
 # -*- coding: utf-8 -*-
 
 import os
Index: llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn
@@ -86,6 +86,7 @@
 
   values = [
     "LLVM_SOURCE_DIR=" + rebase_path("//llvm", dir),
+    "Python3_EXECUTABLE=$python_path",
     "BUILD_MODE=.",
     "LLVM_LIT_CONFIG_MAP=" + config_map,
   ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84625.280830.patch
Type: text/x-patch
Size: 718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200727/d05ccccc/attachment.bin>


More information about the llvm-commits mailing list