[PATCH] D84234: [DWARFYAML] Implement the .debug_loclists section.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-loclists.yaml:426
+##                                                             ^- DW_LLE_start_length
+# ADDRSIZE32-NEXT: 0x00000020 34120000 a1860100                   4.......
+##                            ^-------                            operands[0] (4-byte)
----------------
jhenderson wrote:
> Missing a comment for the end of list markers in both sequences?
It's not the end_of_list marker, it's a counted location description, whose length is 0.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-loclists.yaml:500
+
+## j) Test that an invalid address_size can be used when there are no address-using operators.
+
----------------
jhenderson wrote:
> I think this case is tested by case e)?
Removed.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-loclists.yaml:525-526
+
+## k) Test that yaml2obj emits an error message if we specify invalid numbers of operands
+## for a location list encoding.
+
----------------
jhenderson wrote:
> Looking at this, I think it might be best to test the majority of this in a gtest unit test. It seems like there's a lot of detail that would better fit there. I might be wrong though. What do you think?
I'm not sure. The number of operands is checked in the section emitting period. The gtest unit testing currently only supports testing the YAML parser.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84234/new/

https://reviews.llvm.org/D84234