[PATCH] D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 26 17:00:28 PDT 2020


clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:6773
+
+  auto &outer{std::get<std::optional<parser::DoConstruct>>(x.t)};
+  for (const parser::DoConstruct *loop{&*outer}; loop && level > 0; --level) {
----------------
tskeith wrote:
> This is a good suggestion from clang-tidy. Use `const auto` rather than just `auto` when you can.
Yeah sure. I normally use it when it makes sense. Good catch from clang-tidy!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83998/new/

https://reviews.llvm.org/D83998





More information about the llvm-commits mailing list