[PATCH] D82536: [AVR] Use correct relocation for function pointers in globals

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 25 09:16:13 PDT 2020


aykevl abandoned this revision.
aykevl added a comment.

In D82536#2124348 <https://reviews.llvm.org/D82536#2124348>, @efriedma wrote:

> The way avr-gcc works, the compiler is responsible for figuring this out, not the assembler.  A code pointer should be emitted as `.word gs(func)` i.e. VK_AVR_GS.


Thank you for this!
In that case, I believe this patch is invalid and this feature should be implemented in a different way. However, I honestly have no idea where to even look to get this fixed.

I will abandon this now. The change may be useful for some people but can't be integrated into LLVM as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82536/new/

https://reviews.llvm.org/D82536





More information about the llvm-commits mailing list