[PATCH] D84569: [ELF] --reproduce should include lto sample profile

Christy Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 17:23:12 PDT 2020


christylee marked an inline comment as done.
christylee added inline comments.


================
Comment at: lld/ELF/Driver.cpp:498
       tar->append("version.txt", getLLDVersion() + "\n");
+      StringRef ltoSampleProfile = args.getLastArgValue(OPT_lto_sample_profile);
+      if (!ltoSampleProfile.empty())
----------------
At this point `config->ltoSampleProfile` hasn't been initialized yet so we have to read in the argument value.  However, this seems like the most logical place to append extra stuff to the link repro tar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84569/new/

https://reviews.llvm.org/D84569





More information about the llvm-commits mailing list