[PATCH] D84399: [SCEVExpander] Avoid re-sing existing casts if it means updating users.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

I think this makes sense overall.



================
Comment at: llvm/test/Transforms/LoopDistribute/bounds-expansion-bug.ll:8
+; should only be a small optimization and can be re-introduced once we can
+; properly clean up expansion results, if they are unused.
+
----------------
efriedma wrote:
> Does the pass semantically depend on reusing casts, or does failing to reuse casts just make the generated code uglier?
If this is a single test that actually ensures that casts are reused,
i'm not sure it's a very cornerstone feature of the pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84399/new/

https://reviews.llvm.org/D84399