[PATCH] D83762: [Attributor][WIP] allow multiple branches in followUsesInMBEC

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 13:55:22 PDT 2020


jdoerfert added a comment.

In D83762#2169156 <https://reviews.llvm.org/D83762#2169156>, @okura wrote:

> Sorry for the confusion. I'm thinking about AADereferenceable.
>  The test above exist in dereferenceable-1.ll as @rec-branch-2.
>  The method I used in this patch does not currently handle that case (i.e., cannot deduce dereferenceable(4) for argument %ptr). 
>  I think you expect dereferenceable(4) to be propagated to Known state for argument %ptr at the time after initialize (and followUsesInMBEC) is called.
>  I don't and want to know how to do (for this or follow up patch).


I see. Let's do it in a follow up. It is not clear to me how that would look as we would basically need to do fixpoint iteration and not simply exploration of known facts. It would need to happen in the update, etc.

Are the attached test changes all that occur?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83762/new/

https://reviews.llvm.org/D83762





More information about the llvm-commits mailing list