[PATCH] D84486: [lld-macho] Support -filelist

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/test/MachO/filelist.s:22
+# RUN: lld -flavor darwinnew -Z -filelist filelist %t/test.o -o %t/test
+# RUN: llvm-objdump --syms %t/test | FileCheck %s --check-prefix=SECOND
+
----------------
compnerd wrote:
> I'm not too fond of this test ... it relies on `subsections_via_symbols` not being present which is actually odd for MachO.  An alternative would be to rely on the multiple definitions check to identify the source for the second definition.
not sure I follow. I added `.subsections_via_symbols` (to all 3 input files here) and the test still gave the same result


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84486/new/

https://reviews.llvm.org/D84486