[PATCH] D84105: [MachineVerifier] Speed-up verification (up to 10x)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 11:40:56 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2268
+  DenseSet<const MachineBasicBlock *> Visited;
   while (!RPOWorklist.empty()) {
     auto Next = RPOWorklist.begin();
----------------
This LGTM, but why is the verifier figuring out how to do its own RPO? Why isn't this using ReversePostOrderTraversal<MachineFunction*> which has its own set?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84105/new/

https://reviews.llvm.org/D84105





More information about the llvm-commits mailing list