[PATCH] D82252: MachO: support `-syslibroot`

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 11:23:19 PDT 2020


compnerd marked an inline comment as done.
compnerd added inline comments.


================
Comment at: lld/MachO/Driver.cpp:136
+      for (auto root : roots) {
+        SmallString<261> buffer(root);
+        llvm::sys::path::append(buffer, path);
----------------
int3 wrote:
> any particular reason why you picked 261?
MAX(256, 261) - 261 is the Windows path limit, 256 is the value used on Unix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82252/new/

https://reviews.llvm.org/D82252





More information about the llvm-commits mailing list