[PATCH] D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 09:48:14 PDT 2020


clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:6488
   inExecutionPart_ = false;
+  ResolveAccParts(x);
   ResolveOmpParts(x);
----------------
tskeith wrote:
> clementval wrote:
> > tskeith wrote:
> > > Is it worthwhile skipping this unless `-fopenacc` is present? (Same with OpenMP?)
> > Would make sense I guess. Is there an easy way to query which options are enabled from here? 
> Use `SemanticsContext::IsEnabled` and pass in the `LanguageFeature` for OpenACC or OpenMP.
Thanks. I'll update the patch before landing it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83998/new/

https://reviews.llvm.org/D83998





More information about the llvm-commits mailing list