[PATCH] D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:233
+    for (int i = 0; i < NumBytes; ++i)
+      emitData1(Data[i]);
+    return;
----------------
I'm working on a big-endian target (together with a debugger based on gdb 8.1.0).
I needed to reverse the order here (and in the loop at line 243), to get same result as before. 

Does that make sense? Should we care about endianess in DwarfExpression.cpp?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83560/new/

https://reviews.llvm.org/D83560