[PATCH] D83834: Add test utility 'extract'

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 08:44:51 PDT 2020


lattner added a comment.

Also, it is worth pointing out that we already have an (arguably much better) way to handle the problem you're trying to solve here:

Name your test something like "foo.ll", then have the auxilary files be named "foo.ll.xyz". You can then refer to them directly in the test with "%s.xyz".  This is better because 1) it doesn't introduce another micro tool, 2) it is general to non text files,  3) it is easy to work with on the command line when a test breaks, and 4) this makes it easier for multiple tests to share the same file.

The only downside I see to this is the creation of more small files, but I think it is a good tradeoff to not introduce a new way of doing things here that is less general.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834





More information about the llvm-commits mailing list