[PATCH] D84533: AMDGPU/GlobalISel: Legalize s33 G_ADD, G_SUB and G_MUL

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 07:50:55 PDT 2020


Petar.Avramovic added a comment.

> Would it make more sense for narrow scalar to widen to the next multiple of 32 itself?

Probably yes, at least for add, sub and mul. It could calculate required scalar size and call widenScalar instead on reporting UnableToLegalize.
I am not so sure if this would be correct in general, maybe some opcodes prefer next-power-of-2 instead of multiple of NarrowSize?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84533/new/

https://reviews.llvm.org/D84533





More information about the llvm-commits mailing list