[PATCH] D84500: [ARM] Added additional patterns to VABD instruction

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 06:22:28 PDT 2020


SjoerdMeijer requested changes to this revision.
SjoerdMeijer added a comment.
This revision now requires changes to proceed.

Cheers, this is exactly what I was expecting, one nit inlined.



================
Comment at: llvm/test/CodeGen/Thumb2/mve-vabd.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=thumbv8.1m.main-arm-none-eabi -mattr=+mve.fp %s -o - | FileCheck %s
+
----------------
For bonus points: probably best to add an extra RUN line with just `-mattr=+mve` so that we test this case too, i.e. HasMVEFloat isn't set.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84500/new/

https://reviews.llvm.org/D84500





More information about the llvm-commits mailing list