[PATCH] D84447: [IPConstProp] Replace and move tests to SCCP.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 280420.
fhahn added a comment.

*actually* move the tests to the llvm/test/Transforms/SCCP.

As mentioned in the comments, there are 2 things IPSCCP does not support:

- !callback metadata - that should be straight forward to add (basically switching to abstract call site?)
- ipconstprop solves for each call site separately, so there can be more accurate results for callsites with constant arguments, at cost of (a lot of) compile-time. We could also do something similar in IPSCCP, but have to evaluate if the benefit warrants to extra compile-time. A quick sketch D84521 <https://reviews.llvm.org/D84521>

However I don't think any of the above should block removing ipconstprop, unless there are some real users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84447/new/

https://reviews.llvm.org/D84447

Files:
  llvm/bindings/go/llvm/transforms_ipo.go
  llvm/bindings/ocaml/transforms/ipo/ipo_ocaml.c
  llvm/bindings/ocaml/transforms/ipo/llvm_ipo.mli
  llvm/docs/Passes.rst
  llvm/include/llvm-c/Transforms/IPO.h
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/LinkAllPasses.h
  llvm/include/llvm/Transforms/IPO.h
  llvm/lib/Transforms/IPO/CMakeLists.txt
  llvm/lib/Transforms/IPO/IPConstantPropagation.cpp
  llvm/lib/Transforms/IPO/IPO.cpp
  llvm/test/Transforms/IPConstantProp/2008-06-09-WeakProp.ll
  llvm/test/Transforms/IPConstantProp/PR43857.ll
  llvm/test/Transforms/IPConstantProp/arg-count-mismatch.ll
  llvm/test/Transforms/IPConstantProp/arg-type-mismatch.ll
  llvm/test/Transforms/IPConstantProp/comdat-ipo.ll
  llvm/test/Transforms/IPConstantProp/deadarg.ll
  llvm/test/Transforms/IPConstantProp/multiple_callbacks.ll
  llvm/test/Transforms/IPConstantProp/naked-return.ll
  llvm/test/Transforms/IPConstantProp/openmp_parallel_for.ll
  llvm/test/Transforms/IPConstantProp/pthreads.ll
  llvm/test/Transforms/IPConstantProp/recursion.ll
  llvm/test/Transforms/IPConstantProp/return-argument.ll
  llvm/test/Transforms/IPConstantProp/return-constant.ll
  llvm/test/Transforms/IPConstantProp/return-constants.ll
  llvm/test/Transforms/IPConstantProp/thread_local_acs.ll
  llvm/test/Transforms/SCCP/2008-06-09-WeakProp.ll
  llvm/test/Transforms/SCCP/PR43857.ll
  llvm/test/Transforms/SCCP/arg-count-mismatch.ll
  llvm/test/Transforms/SCCP/arg-type-mismatch.ll
  llvm/test/Transforms/SCCP/comdat-ipo.ll
  llvm/test/Transforms/SCCP/deadarg.ll
  llvm/test/Transforms/SCCP/multiple_callbacks.ll
  llvm/test/Transforms/SCCP/naked-return.ll
  llvm/test/Transforms/SCCP/openmp_parallel_for.ll
  llvm/test/Transforms/SCCP/pthreads.ll
  llvm/test/Transforms/SCCP/recursion.ll
  llvm/test/Transforms/SCCP/return-argument.ll
  llvm/test/Transforms/SCCP/return-constant.ll
  llvm/test/Transforms/SCCP/return-constants.ll
  llvm/test/Transforms/SCCP/thread_local_acs.ll
  llvm/utils/findoptdiff
  llvm/utils/gn/secondary/llvm/lib/Transforms/IPO/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84447.280420.patch
Type: text/x-patch
Size: 33535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200724/a252c063/attachment.bin>