[PATCH] D84493: [InstCombine] Disable branch predicate canonicalization

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Since out of all 3 patches this is the one with comments, i'll reply here.
I'm not a fan of this direction. You'll need to additionally cripple
`canonicalizeICmpPredicate()`, `canFreelyInvertAllUsersOf()`,
possibly their users. I'm not sure it conceptually makes sense
to do that in SimplifyCFG. But it for sure will restrict InstCombine.

Was the other proper solution of either updating PDT, or making it order-insensitive explored and turned out to be impossible?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84493/new/

https://reviews.llvm.org/D84493