[PATCH] D84064: [flang][openacc] OpenACC module signature

Thu Jul 23 20:44:31 PDT 2020

clementval marked 2 inline comments as done.
clementval added inline comments.

================
Comment at: flang/module/openacc.f90:186
+
+contains
+  ! 3.2.1
----------------
klausler wrote:
> clementval wrote:
> > klausler wrote:
> > > Is your intent to implement these subprograms here in this module eventually?
> > > 
> > > If so, it might be better to define their `module` interfaces here in the module, and put their implementations into one or more submodules.
> > > 
> > > If not, then these subprograms should probably be just interfaces.
> > They will most probably be implemented in other module/submodule so I made them interfaces. 
> If they're going to be implemented in a submodule (which makes sense to me), these interfaces should be `module` functions and subroutines.  They can't be implemented in another module.
Yeah right. I'm gonna update this module and the patch. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84064/new/

https://reviews.llvm.org/D84064