[PATCH] D83834: Add test utility 'extract'

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 19:20:38 PDT 2020


dblaikie added a comment.

In D83834#2171199 <https://reviews.llvm.org/D83834#2171199>, @MaskRay wrote:

> Use %extract only in `not %extract`


So does 'extract' not work the same as all other tools in LLVM? It doesn't get substituted in non-starting locations?

That inconsistency seems undesirable/best avoided. The xray collission is problematic, to be sure - might indicate that another name should be used, or perhaps some escaping to disable substitution would be useful (quotation marks seem like a fairly accessible/simple syntax to disable substitution, for instance)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834





More information about the llvm-commits mailing list