[PATCH] D84365: [WebAssembly] Fix store_unfolded_offset tests in simd-offset.ll

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 14:04:48 PDT 2020


tlively added a comment.

In D84365#2168515 <https://reviews.llvm.org/D84365#2168515>, @aheejin wrote:

> They seem to have been written that way because negative offsets aren't folded <https://github.com/llvm/llvm-project/blob/c0185dc7df86c763837916771d02c4a5e1b44dbf/llvm/test/CodeGen/WebAssembly/offset.ll#L44>? What does it mean that they are duplicates of other patterns?


Sorry, I could have been more clear. The old bodies of the store_with_unfolded_offset tests were the same as the bodies of the store_with_unfolded_gep_negative_offset tests. This was probably a copy-paste error when I first created this file from offset.ll.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84365/new/

https://reviews.llvm.org/D84365





More information about the llvm-commits mailing list