[PATCH] D82680: MSAN: Allow emitting checks for struct types

Gui Andrade via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 09:52:50 PDT 2020


guiand marked 5 inline comments as done.
guiand added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1428
+    assert(VTy->isIntegerTy());
+    if (VTy->getIntegerBitWidth() == 1)
+      // Convert bool to bool is a nop
----------------
vitalybuka wrote:
> do you see a difference without this check?
If you look at msan_x86_bts_asm.ll, this check eliminates an unnecessary icmp in some cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82680/new/

https://reviews.llvm.org/D82680





More information about the llvm-commits mailing list