[PATCH] D84379: PGO][InstrProf] Do not promote count if the exit blocks contains ret instruction

[David Li via Phabricator via llvm-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:292
+    // of the loop, the result profile is incomplete.
+    if (SkipRetExitBlock) {
+      for (auto BB : ExitBlocks)
----------------
Add a //FIXME here to add other heuristics to detect long running loop (runtime infinite), e.g. exit condition etc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84379/new/

https://reviews.llvm.org/D84379