[PATCH] D84378: [PGO] Fix incorrect function entry count

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 09:02:05 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1144
+    // Fix it if necessary.
+    if (InstrBB == FuncEntry && CountValue == 0)
+      CountValue = 1;
----------------
add comment here about the root cause: counter cleared before dump. 

If counter promotion is disabled, in what situation entry count can not be recovered with propagation?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84378/new/

https://reviews.llvm.org/D84378





More information about the llvm-commits mailing list