[PATCH] D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities

Sidharth Baveja via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 08:29:14 PDT 2020


sidbav marked 2 inline comments as done.
sidbav added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:28
-#include "llvm/IR/InstrTypes.h"
-#include "llvm/IR/Instruction.h"
-#include "llvm/IR/Instructions.h"
----------------
fhahn wrote:
> I am still not sure why those includes were removed? If they are not needed independently of this change, it should be a separate patch. Usually we include what is used in each .cpp file. Things might build because some headers are included by other headers in turn, but usually we do not rely on that.
Updated the file to such that all of the includes from before are included. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83056/new/

https://reviews.llvm.org/D83056





More information about the llvm-commits mailing list