[PATCH] D84323: [llvm-readelf/readobj] - Detemplate printRelRelaReloc() methods.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I'm no more a fan of using Elf_Rel for Elf_Rela relocations than I was of using Elf_Rela for Elf_Rel, even with the extra Addend argment. I think if we are to go down this road, I'd split it up into its component parts in the first instance, but that might become too many arguments.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6448
     for (const Elf_Rel &Rel : this->dumper()->dyn_rels())
-      printDynamicRelocation(Obj, Rel);
+      printDynamicRelocation(Obj, Rel, /*Addend*/None);
   }
----------------
I think `/*Addend=*/None` is the preferred style. Same below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84323/new/

https://reviews.llvm.org/D84323