[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1079
+                           cast<Constant>(DFSanUseFast16LabelsFn.getCallee()),
+                           "__dfsan_fast16labels_preinit");
+    UseFast16LabelsInit->setSection(".preinit_array");
----------------
what we are going to do in __dfsan_fast16labels_preinit?


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1339
+        IRB.CreateAlignedLoad(IRB.getInt64Ty(), WideAddr, ShadowAlign);
+    for (uint64_t Ofs = 64 / DFS.ShadowWidthBits; Ofs != Size;
+         Ofs += 64 / DFS.ShadowWidthBits) {
----------------
have you considered a loop?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84371/new/

https://reviews.llvm.org/D84371