[PATCH] D83833: [GISel] Add new GISel combiners for G_SELECT

Michael Kitzan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 17:14:58 PDT 2020


mkitzan added inline comments.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:214
+
+// Fold (cmp ? x : undef) -> x
+// Fold (cmp ? undef : y) -> y
----------------
arsenm wrote:
> arsenm wrote:
> > This may not be correct? See 1cf6f210a2ed87dcda2183fffd6f9aa17b5c493c
> Probably should split this into its own patch since it's questionable?
Sounds reasonable. Will split that combine off into another patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83833/new/

https://reviews.llvm.org/D83833





More information about the llvm-commits mailing list