[PATCH] D79485: [BPI] Improve static heuristics for "cold" paths.

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 14:52:42 PDT 2020


Discard this comment -- this is intended for a different patch.

On Wed, Jul 22, 2020 at 2:52 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> The PGOUse pass can choose not to annotate any branches with total weights
> == 0. Now the question becomes how do we tell PGOUse pass whether the entry
> should be set to 0 or leave it not set. There are two ways to do it (to
> signal it is not really cold, but unknown):
>
> 1. Remove the function from the indexed format profile;
> 2. set all counts to some sentinel value such as -1.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D79485/new/
>
> https://reviews.llvm.org/D79485
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200722/beeebf49/attachment.html>


More information about the llvm-commits mailing list