[PATCH] D83592: [Coverage] Add comment to skipped regions

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 14:52:09 PDT 2020


zequanwu added a comment.

In D83592#2167926 <https://reviews.llvm.org/D83592#2167926>, @vsk wrote:

> @zequanwu I'm not sure whether this is something you've already tried, but for frontend changes, it can be helpful to verify that a stage2 clang self-host with assertions enabled completes  successfully. For coverage specifically, it's possible to do that by setting '-DLLVM_BUILD_INSTRUMENTED_COVERAGE=On' during the stage2 cmake step.


I didn't know that before. I will try.

When including some standard libraries, the assertion `assert(SM.isWrittenInSameFile(LocStart, LocEnd) && "region spans multiple files");` fails, like <stdlib.h> or <cmath> etc, still investigating.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83592/new/

https://reviews.llvm.org/D83592





More information about the llvm-commits mailing list