[PATCH] D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir

Wed Jul 22 10:58:28 PDT 2020

tra added a comment.

In D84256#2166061 <https://reviews.llvm.org/D84256#2166061>, @kuhnel wrote:

> Sorry I did not understand why do you want to move these files. 
>  Why not keep the new docker files for the existing machines right next to the existing ones?
>
> So my thought on the directory structure was:
>
> - /buildbot/google/
>   - docker/
>     - mlir-nvidia/
>     - win32/
>     - your-docker-dir/
>     - some-other-bot/
>     - <common scripting>

I'm fine with this part.

> - terraform/
>   - <one terraform config for all machines>

That's the part I'm not quite sure about. Terraform is an all-or-nothing kind of thing. I.e. `terraform apply` will try to set thing up for *everything* described in main.tf. I'm not convinced that we should mix all our bot setups here. I don't want MLIR folks and myself stepping on each other's toes and affecting each others' cluster setups. We may eventually consolidate them, but I don't think we're there yet.

Hence, I have my own terraform setup. We could structure it similarly to your suggestion for the docker files -- move current files under terraform/mlir and mine under terraform/cudabot, but with mlir and cudabot setups being split everywhere, we may as well maintain mlir and cudabot separately.

Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84256/new/

https://reviews.llvm.org/D84256