[PATCH] D84293: Add an assertion in SmallVector::push_back()

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 10:08:34 PDT 2020


mehdi_amini marked an inline comment as done.
mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInst.h:187
+    Operands.push_back(Op);
+  }
 
----------------
Actually this is working around the assertion, but not fixing it.
The reference passed as input is invalidated by the reserve I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84293/new/

https://reviews.llvm.org/D84293





More information about the llvm-commits mailing list