[PATCH] D84231: [llvm-readobj] - Don't get the name of the symbol table in ELFDumper<ELFT>::printSymbolsHelper.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 23:05:41 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3982
+      this->reportUniqueWarning(createError(
+          "unable to get the name of the symbol table section with index " +
+          Twine(SecNdx) + ": " + toString(NameOrErr.takeError())));
----------------
The original messages carry more information as a symbol table can represent either  SHT_DYNSYM or SHT_SYMTAB... I am fine combing them, though


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84231/new/

https://reviews.llvm.org/D84231





More information about the llvm-commits mailing list